From 7a57cd9ccfabef56acd420f9e22e13838092f111 Mon Sep 17 00:00:00 2001
From: Paul-Louis NECH <pln@algolia.com>
Date: Sat, 2 Nov 2019 19:18:25 +0100
Subject: [PATCH] feat(layout): Better cards

---
 .github/README.png                          | Bin 259128 -> 0 bytes
 app/src/main/res/layout/contact.xml         | 23 +++++++++++++----------
 app/src/main/res/layout/content_friends.xml |  4 ++--
 3 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/.github/README.png b/.github/README.png
index c86239a..8dfe720 100644
Binary files a/.github/README.png and b/.github/README.png differ
diff --git a/app/src/main/res/layout/contact.xml b/app/src/main/res/layout/contact.xml
index 182ff38..4339c45 100644
--- a/app/src/main/res/layout/contact.xml
+++ b/app/src/main/res/layout/contact.xml
@@ -5,20 +5,19 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
+    android:layout_marginBottom="4dp"
+    android:layout_marginTop="0dp"
     android:elevation="5dp">
 
     <androidx.constraintlayout.widget.ConstraintLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content">
 
-
         <ImageView
             android:id="@+id/pic"
             android:layout_width="150dp"
-            android:layout_height="100dp"
-            android:layout_marginTop="5dp"
-            android:layout_marginEnd="10dp"
-            android:layout_marginBottom="5dp"
+            android:layout_height="0dp"
+            android:layout_marginEnd="8dp"
             android:height="150dp"
             android:contentDescription="TODO"
             android:elevation="2dp"
@@ -41,13 +40,14 @@
             app:layout_constraintBottom_toTopOf="@id/contactData"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toEndOf="@id/pic"
-            app:layout_constraintTop_toTopOf="parent"
+            app:layout_constraintTop_toTopOf="@id/pic"
             tools:text="@tools:sample/full_names" />
 
         <TextView
             android:id="@+id/contactData"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
+            android:layout_marginStart="8dp"
             android:layout_marginEnd="15dp"
             android:focusable="false"
             android:focusableInTouchMode="false"
@@ -81,16 +81,17 @@
             style="@style/Widget.MaterialComponents.Button.OutlinedButton"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginStart="10dp"
-            android:layout_marginEnd="10dp"
+            android:layout_marginStart="8dp"
+            android:layout_marginBottom="8dp"
             android:text="Text"
             android:visibility="invisible"
             app:icon="@android:drawable/ic_menu_send"
             app:layout_constraintBottom_toBottomOf="parent"
-            app:layout_constraintHorizontal_bias="1.0"
             app:layout_constraintEnd_toStartOf="@id/contactCall"
+            app:layout_constraintHorizontal_bias="1.0"
             app:layout_constraintStart_toEndOf="@id/pic"
             app:layout_constraintTop_toBottomOf="@id/contactPhone"
+            app:layout_constraintVertical_bias="1.0"
             tools:visibility="visible" />
 
         <com.google.android.material.button.MaterialButton
@@ -98,10 +99,12 @@
             style="@style/Widget.MaterialComponents.Button.OutlinedButton"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="8dp"
+            android:layout_marginBottom="8dp"
             android:text="Call"
             android:visibility="invisible"
             app:icon="@android:drawable/ic_menu_call"
-            app:layout_constraintBottom_toBottomOf="@id/contactText"
+            app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toEndOf="@id/contactText"
             app:layout_constraintTop_toBottomOf="@id/contactPhone"
diff --git a/app/src/main/res/layout/content_friends.xml b/app/src/main/res/layout/content_friends.xml
index 14d32a1..93351a0 100644
--- a/app/src/main/res/layout/content_friends.xml
+++ b/app/src/main/res/layout/content_friends.xml
@@ -10,10 +10,10 @@
 
     <TextView
         android:id="@+id/welcomeTitle"
-        android:layout_marginTop="10dp"
-        android:layout_marginBottom="10dp"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
+        android:layout_marginTop="8dp"
+        android:layout_marginBottom="8dp"
         android:textSize="24sp"
         app:layout_constraintBottom_toTopOf="@id/friendsList"
         app:layout_constraintLeft_toLeftOf="parent"
--
libgit2 0.27.0